Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:slider): processing value zero correctly #6729

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #6635

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 31, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #6729 (f70da52) into master (f9e7d23) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6729      +/-   ##
==========================================
- Coverage   89.92%   89.91%   -0.02%     
==========================================
  Files         481      480       -1     
  Lines       15403    15362      -41     
  Branches     2492     2490       -2     
==========================================
- Hits        13851    13812      -39     
+ Misses        931      930       -1     
+ Partials      621      620       -1     
Impacted Files Coverage Δ
components/slider/slider.component.ts 90.40% <100.00%> (ø)
components/date-picker/date-picker.component.ts 90.90% <0.00%> (-2.47%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 90.21% <0.00%> (-0.21%) ⬇️
components/date-picker/date-picker.module.ts 100.00% <0.00%> (ø)
components/date-picker/picker.component.ts
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (+0.70%) ⬆️
components/date-picker/testing/util.ts 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e7d23...f70da52. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev added this to the v12 milestone Jun 4, 2021
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 62a86c0 into NG-ZORRO:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider default value
3 participants