Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:affix): fix affix nzOffsetTop bug #868

Merged
merged 1 commit into from
Jan 6, 2018
Merged

fix(module:affix): fix affix nzOffsetTop bug #868

merged 1 commit into from
Jan 6, 2018

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.852% when pulling b80a527 on vthinkxie:fix-affix into 0384eec on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit f0bad26 into NG-ZORRO:master Jan 6, 2018
@pjurczynski
Copy link
Contributor

@vthinkxie do you by any chance remember what were the steps to reproduce this bug?

@vthinkxie
Copy link
Member Author

@pjurczynski set any value to nzOffsetTop will reproduce this bug, string + number will return a string, like '6'+ 10 will return '610' but not 16

@vthinkxie vthinkxie deleted the fix-affix branch October 10, 2018 02:49
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants