Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:progress): fix 100% when specify invalid value #905

Merged
merged 1 commit into from
Jan 15, 2018
Merged

fix(module:progress): fix 100% when specify invalid value #905

merged 1 commit into from
Jan 15, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 12, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #903

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@@ -87,7 +87,7 @@ export class NzProgressComponent implements ControlValueAccessor, OnInit {
}

writeValue(value: number): void {
this._percent = value;
this._percent = typeof value === 'undefined' || value === null ? 0 : +value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeof value === 'undefined' || value === null equals to value == null

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 39.861% when pulling dd28ae8 on cipchk:issues-903 into 1662383 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 39.871% when pulling de02aae on cipchk:issues-903 into 1662383 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 8afedaa into NG-ZORRO:master Jan 15, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants