Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting (in particular the tests) #275

Open
florian-huber opened this issue Dec 17, 2020 · 0 comments
Open

Linting (in particular the tests) #275

florian-huber opened this issue Dec 17, 2020 · 0 comments

Comments

@florian-huber
Copy link
Member

When switching on the linter in #273 I came across quiet some linter issues. Some are solved in #273, and some I assume we don't want to "fix" (e.g. having many arguments is part of the deep learning game...).
But many of the tests also caused linter issues and in some cases I was wondering if we weren't missing some additional asserts etc.
So, maybe we can:

  • set the linter profile a bit stricter and address the raised warnings
  • Check the actual test coverage, e.g. by adding SonarCloud?
  • Check the unit tests and see if they contain the right asserts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant