Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC2 - not tested in matrix #1040

Open
JessicaMeixner-NOAA opened this issue Jul 17, 2023 · 1 comment
Open

IC2 - not tested in matrix #1040

JessicaMeixner-NOAA opened this issue Jul 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@JessicaMeixner-NOAA
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
IC2 does not appear to be tested in the matrix of regression tests.

Describe the solution you'd like
Should have a test.

Additional context
This was noticed as a typo for IC2 precompiler directive was not noticed originally through regression testing: #1039

@JessicaMeixner-NOAA JessicaMeixner-NOAA added the enhancement New feature or request label Jul 17, 2023
@ukmo-ccbunney
Copy link
Collaborator

A quick grep in the regtests directory suggests that there are tests that have IC2 as a switch:

/data/users/frey/WW3Git/UKMO_WW3/regtests [branch: feature/gpu/w3srce_refactor]
frey@vld225:> grep -l  IC2 */input*/switch*
ww3_tic1.1/input_IC2_ifr/switch
ww3_tic1.1/input_IC2_ifr/switch_IC2IS2
ww3_tic1.1/input_IC2_nondisp/switch
ww3_tic1.1/input_IC2_nrl/switch
ww3_tic1.4/input/switch_IC2IS2
ww3_tic2.3/input/switch_IC2IS2
ww3_tp2.14/input_oasacm2/switch_OASACM2
ww3_tp2.14/input_oasacm3/switch_OASACM3
ww3_tp2.14/input_oasacm4/switch_OASACM4
ww3_tp2.14/input_oasacm5/switch_OASACM5
ww3_tp2.14/input_oasacm6/switch_OASACM6
ww3_tp2.14/input_oasacm/switch_OASACM
ww3_tp2.14/input_oasicm/switch_OASICM
ww3_tp2.14/input_oasocm/switch_OASOCM
ww3_ts1/input_icesct_IC2/switch
ww3_ts4/input_rg_multi/switch
ww3_ts4/input_rg_multi/switch_MPI
ww3_ts4/input_rg_shel/switch
ww3_ts4/input_rg_shel/switch_MPI
ww3_ts4/input_ug/switch
ww3_ts4/input_ug/switch_MPI

so I don't really understand why they were not failing to compile. I will investigate a bit deeper when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants