Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable USSP_WN is not initialized for full array #1160

Closed
JessicaMeixner-NOAA opened this issue Jan 5, 2024 · 0 comments · Fixed by #1165
Closed

Variable USSP_WN is not initialized for full array #1160

JessicaMeixner-NOAA opened this issue Jan 5, 2024 · 0 comments · Fixed by #1165
Assignees
Labels
bug Something isn't working

Comments

@JessicaMeixner-NOAA
Copy link
Collaborator

Describe the bug
The variable USSP_WN is not initialized in model/src/w3gridmd.F90 before being written to mod_def. Most compilers initlized to zero so it has gone undetected so far. Moreover, it is initialized for the part of the array that is actually used in the code, so it's a non-issue other than ensuring reproducible on machines where the uninitialized part is randomly assigned.

To Reproduce
Find a compiler/debug option that initliaizes variables to random values, use ASCII output to print out values mod_defs and you will note that USSP_WN is not bit-for-bit between runs and a cause of mod_defs not being reproducible.

Expected behavior
Mod_defs should be reproducible between runs.

Additional context
A fix is coming soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant