Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocation of un-needed arrays in dev/ufs-weather-model #1315

Open
DeniseWorthen opened this issue Nov 8, 2024 · 0 comments
Open

allocation of un-needed arrays in dev/ufs-weather-model #1315

DeniseWorthen opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@DeniseWorthen
Copy link
Contributor

The configurations used in the dev/ufs-weather-model branch utilize the CMEPS mediator to provide importState fields from other model components at each ModelAdvance for WW3.

Currently, the mesh cap allocates and fills the fields required by WW3 for two time levels of these import fields---eg, CX0 and CXN. The "next" fields are simply set equal to the "current" fields for the purposes of making WW3 happy when it "time interpolates" the forcing fields in w3updtmd. However, since T0==TN, the end result after w3updtmd is that CX==CX0.

The concept of time-interpolating the forcing fields is meaningless for the configurations where CMEPS is providing updated importState fields at a single time. The allocation of CXN simply wastes memory, as does the allocation of arrays which are associated with the time-interpolation and which serve no purpose. For the ocean currents, this includes arrays CA0,CAI,CD0,CDI.

Depending on configuration, the total number of unnecessary arrays is 15, all of which are allocated as the global domain on each DE. Testing indicates these arrays can be safely allocated to size=1, the "time interpolation" in w3updtmd can be skipped and all model results are B4B in UFS. This reduces the memory footprint for the dev/ufs-weather-model branch. Initial testing has indicated some potential for also speeding the integration time. A PR is being prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant