Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in output of the Goda (1970) peakedness parameter #210

Closed
CarstenHansen opened this issue Jun 9, 2020 · 5 comments
Closed

Error in output of the Goda (1970) peakedness parameter #210

CarstenHansen opened this issue Jun 9, 2020 · 5 comments

Comments

@CarstenHansen
Copy link
Contributor

Kaushik Sasmal has identified unrealistic output values of QP and raised a question to [email protected].
In ftn/w3iogomd.ftn (master and develop branches) the contribution from the spectral tail is added as:

EET1(JSEA)= ET1(JSEA) + FT1 * EBAND**2

In this line ET1 should rather be EET1:

    EET1(JSEA)= EET1(JSEA) + FT1  * EBAND**2

The consequence of this code error is, if the contribution of the spectral tail is negligible, that in the expression QP = 2 EET1 / ET^2 / (2pi)^2, EET1 is exchanged with ET1, the integrated 1’st moment of the spectrum (m^2/s). ET is the total variance (m^2).

@CarstenHansen
Copy link
Contributor Author

CarstenHansen commented Jun 9, 2020

A more consistent tail contribution would be

 EET1(JSEA) = EET1(JSEA) + FT2 * EBAND**2

using a new factor

 FT2 = 0.1666 * SIG(NK)**2 * DTH * SIG(NK) = 0.5 * FT1

here assuming the frequency spectrum tail is proportional to SIG^{-4}.
The difference between FT1 and FT2 doesn't matter much, because the purpose of adding the tail here seems mainly to provide a smooth transition towards zero when most of the spectral energy is near the upper frequency SIG(NK).

@CarstenHansen
Copy link
Contributor Author

The tail extension to spectral partitions also seems wrong:

SUMQP(IP) = SUMQP(IP) + SUMF (NK,IP) * FTEII

It should rather be (I think):

    SUMQP(IP) = SUMQP(IP) + SUMF (NK,IP)**2 * FTEII * (0.1666 / 0.25)

@aliabdolali
Copy link
Contributor

@CarstenHansen have you solved this issue?

@CarstenHansen
Copy link
Contributor Author

CarstenHansen commented Nov 2, 2022

Hi @aliabdolali . Unfortunately, I did not see your comment until I was browsing through the Issues last week. I have been in a misunderstanding that Goda's parameter is not of interest except for historical comparisons, but it is actually used for verification of observational systems, e.g. by Le Merle et al. (2021) and others.

So, I have carefully re-calculated the expressions that should correctly be in the code and prepared a bugfix out of the current develop branch: https://github.com/CarstenHansen/WW3/tree/bf_qp .

Based on the bugfix I have tested and verified the results of ww3_shel in two realistic hotsim runs as explained in the first commit message 75843a8, for model setup with DTH = 10 degrees and 15 degrees, respectively.

@CarstenHansen CarstenHansen mentioned this issue Jul 31, 2023
Merged
@CarstenHansen
Copy link
Contributor Author

Closing this because of long term inactivity.

Note that the tail extension to spectral partitions for QP is still wrong

SUMQP(IP) = SUMQP(IP) + SUMF (NK,IP) * FTEII

It should rather be (I think):

     SUMQP(IP) = SUMQP(IP) + SUMF (NK,IP)**2 * FTEII * (0.1666 / 0.25)

@CarstenHansen CarstenHansen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants