-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in output of the Goda (1970) peakedness parameter #210
Comments
A more consistent tail contribution would be
using a new factor
here assuming the frequency spectrum tail is proportional to SIG^{-4}. |
The tail extension to spectral partitions also seems wrong: Line 1222 in 7823bd2
It should rather be (I think):
|
@CarstenHansen have you solved this issue? |
Hi @aliabdolali . Unfortunately, I did not see your comment until I was browsing through the Issues last week. I have been in a misunderstanding that Goda's parameter is not of interest except for historical comparisons, but it is actually used for verification of observational systems, e.g. by Le Merle et al. (2021) and others. So, I have carefully re-calculated the expressions that should correctly be in the code and prepared a bugfix out of the current develop branch: https://github.com/CarstenHansen/WW3/tree/bf_qp . Based on the bugfix I have tested and verified the results of ww3_shel in two realistic hotsim runs as explained in the first commit message 75843a8, for model setup with DTH = 10 degrees and 15 degrees, respectively. |
Closing this because of long term inactivity. Note that the tail extension to spectral partitions for QP is still wrong Line 1384 in 7bec560
It should rather be (I think):
|
Kaushik Sasmal has identified unrealistic output values of QP and raised a question to [email protected].
In ftn/w3iogomd.ftn (master and develop branches) the contribution from the spectral tail is added as:
WW3/model/ftn/w3iogomd.ftn
Line 1860 in 7823bd2
In this line ET1 should rather be EET1:
The consequence of this code error is, if the contribution of the spectral tail is negligible, that in the expression QP = 2 EET1 / ET^2 / (2pi)^2, EET1 is exchanged with ET1, the integrated 1’st moment of the spectrum (m^2/s). ET is the total variance (m^2).
The text was updated successfully, but these errors were encountered: