Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_cmake_test force to copy ww3_prtide #837

Closed
mickaelaccensi opened this issue Oct 25, 2022 · 1 comment · Fixed by #1049
Closed

run_cmake_test force to copy ww3_prtide #837

mickaelaccensi opened this issue Oct 25, 2022 · 1 comment · Fixed by #1049
Assignees
Labels
bug Something isn't working

Comments

@mickaelaccensi
Copy link
Collaborator

mickaelaccensi commented Oct 25, 2022

Describe the bug
run_cmake_test always try to copy the non-SHRD exe from the build directory to path_e even if ww3_prtide was not compiled (switch TIDE not present in the switch file)

To Reproduce
when running almost the regtests

Expected behavior
in run_cmake_test, add a test if file exists
if [[ -e $path_build/install/bin/ww3_prtide ]] ; then
cp $path_build/install/bin/ww3_prtide $path_e/
fi

@mickaelaccensi mickaelaccensi added the bug Something isn't working label Oct 25, 2022
@mickaelaccensi mickaelaccensi self-assigned this Oct 25, 2022
@JessicaMeixner-NOAA
Copy link
Collaborator

@mickaelaccensi good idea! Instead of just checking that it exists, should we only even try to copy if the TIDE switch is there, that way then if that does not exist we could have an error? Should we do that for all of the executables perhaps even? Have a list of exes that need to be copied, and if they don't exist, exit with an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants