You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue proposes to remove clocks in atm_land_ice_flux_exchange_mod in full coupler.
In full coupler, clocks are set in the coupler_main program as well as in _*flux_exchange modules. Some of the clocks in coupler_main and *flux_exchange modules overlap in functionality.
For example, in atm_land_ice_flux_exchange_mod, clocks sfcClock, fluxAtmDnClock,regenClock, and fluxAtmUpClock are initialized in subroutine atm_land_ice_flux_exchange_init. These clocks begin at the beginning and end at the end of its respective subroutines - sfc_boundary_layer, flux_down_from_atmos, generate_sfc_xgrid, flux_up_to_atmos - to gather runtime information.
Simultaneously, clocks newClockb, newClockd, newClock1, and newClockg in coupler_main program are initialized in subroutine coupler_init and begin before calls to its respective subroutines - sfc_boundary_layer, flux_down_from_atmos, generate_sfc_xgrid, flux_up_to_atmos - and end post call.
The set of clocks in atm_land_ice_flux_exchange_mod and set of clocks in coupler_main seem to measure the same processes. The only seemingly difference between the two sets is time measurement being done internally or externally. Thus, the redundant set of clocks in atm_land_ice_flux_exchange_mod could be removed without any loss of diagnostic information.
The text was updated successfully, but these errors were encountered:
mlee03
changed the title
Remove redundant clocks in flux exchange modules
refactorization: Remove redundant clocks in flux exchange modules
May 17, 2024
This issue proposes to remove clocks in
atm_land_ice_flux_exchange_mod
in full coupler.In full coupler, clocks are set in the coupler_main program as well as in _*flux_exchange modules. Some of the clocks in coupler_main and *flux_exchange modules overlap in functionality.
For example, in atm_land_ice_flux_exchange_mod, clocks
sfcClock
,fluxAtmDnClock
,regenClock
, andfluxAtmUpClock
are initialized in subroutine atm_land_ice_flux_exchange_init. These clocks begin at the beginning and end at the end of its respective subroutines -sfc_boundary_layer
,flux_down_from_atmos
,generate_sfc_xgrid
,flux_up_to_atmos
- to gather runtime information.Simultaneously, clocks
newClockb
,newClockd
,newClock1
, andnewClockg
in coupler_main program are initialized in subroutine coupler_init and begin before calls to its respective subroutines -sfc_boundary_layer
,flux_down_from_atmos
,generate_sfc_xgrid
,flux_up_to_atmos
- and end post call.The set of clocks in atm_land_ice_flux_exchange_mod and set of clocks in coupler_main seem to measure the same processes. The only seemingly difference between the two sets is time measurement being done internally or externally. Thus, the redundant set of clocks in atm_land_ice_flux_exchange_mod could be removed without any loss of diagnostic information.
The text was updated successfully, but these errors were encountered: