Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(*)Fixes gprime(1) when no layer coordinates are set
- The "none" option for COORD_CONFIG literally did nothing which meant that Rlay and gprime were unset (they actually appeared to be zero). This mode was added with the intent that the model should not need these coordinate variables in ALE mode. However, gprime(k=1) is used and should be set to GFS, which this commit now does. - I also added "ALE" as an option for COORD_CONFIG which is equivalent to "none" since "ALE" is bit more intuitive. - We might even use this as a master switch or check that COORD_CONFIG is consistent with USE_REGRIDDING (for later)? - This commit "appears" to changes answers but I don't think it does. What changes is the calculation of energy for some experiments in which Rlay was not set before this commit. A non-zero gprime(1) produces different APEs. Experiments affected are: - CVmix_SCM_tests/cooling_only/EPBL - CVmix_SCM_tests/cooling_only/KPP - CVmix_SCM_tests/mech_only/EPBL - CVmix_SCM_tests/mech_only/KPP - CVmix_SCM_tests/skin_warming_wind/EPBL - CVmix_SCM_tests/skin_warming_wind/KPP - CVmix_SCM_tests/wind_only/EPBL - CVmix_SCM_tests/wind_only/KPP - SCM_idealized_hurricane - single_column/EPBL - single_column/KPP - unit_tests All the above have COORD_CONFIG="none".
- Loading branch information