Revert backslash escapes to git-version-string output #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2020 10:44
This reverts commit 1a60b1a. Revert the update to `mkmf -g` option that escaped the double quotes around the call to `git-version-string`. The reason is that this update causes some compiler wrappers to have quoting problems (NOAA-GFDL#33) that resulted in `git-version-string`'s output not being quoted as needed.
|
Simply reverting the backslash ( |
|
Gotcha, will close this. Quoting issues are tricky for sure. |
|
@ceblanton, @bensonr responded to #33 with information on what required the backslash. It was a quoting issue when using the Intel MPI compiler wrappers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the recent update that escaped the quotes in the call to
git-version-stringinmkmf.Also updates the
mkmfversion number.Resolves #33