Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent check return type #68

Open
Cesar199999 opened this issue Jun 17, 2024 · 0 comments
Open

Fix inconsistent check return type #68

Cesar199999 opened this issue Jun 17, 2024 · 0 comments

Comments

@Cesar199999
Copy link

LinearCodePCS::check, which can Err when there is a genuine runtime error during verification OR when no runtime errors occur but the proof is rejected; and, in the latter case, sometimes Ok(false) is returned instead.

In order to fix this, check must return Ok(false) when the proof is rejected due to cryptographic checks, and Err only when there is a genuine runtime error during verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant