-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move metadata generation (Alfalfa Ruby gem) into core OS #506
Comments
@TShapinsky @kbenne please document approach and pros/cons here. |
Moving Alfalfa metadata generation library into OS SDKPros:
Cons:
Keeping Alfalfa ruby gem as separate codePros:
Cons:
Other thoughtsRight now models processed by alfalfa are not portable because the external interface of E+ requires a socket connection to tell it when to advance. Additionally the functions that the alfalfa gem accomplishes are not trivial because of how we've had to work around the limitations of the external interface. Transitioning to pyenergyplus from external interface makes the job of adding points to alfalfa much simpler. This is because creating inputs and outputs will no longer require modifications to the underlying model. This means that the only thing that model needs for alfalfa is metadata telling alfalfa which points to expose. I don't think it makes sense to move to alfalfa metadata in the OS SDK until we are in the process of migrating to pyenergyplus. This is because the functions needed to implement metadata generation will become much simpler and are less likely to require changes in the future. Additionally, before we transition to pyenergyplus the models post alfalfa aren't portable anyways due to the inclusion of external interface. |
This is added to our roadmap with the following timing:
|
After talking with @kbenne the alflalfa point list will be stored in the |
update from standup - @TShapinsky's current OS code reviewed by @kbenne. next steps to get this merged into OS:
|
Nice work @TShapinsky ! |
For discussion: target 9/24 release of OS. Staffing on OS side?
The text was updated successfully, but these errors were encountered: