Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass PyObject instead of str into CompassApp.run method #203

Open
robfitzgerald opened this issue May 9, 2024 · 0 comments
Open

Pass PyObject instead of str into CompassApp.run method #203

robfitzgerald opened this issue May 9, 2024 · 0 comments
Labels
python Applies to the python code rust Applies to the rust code

Comments

@robfitzgerald
Copy link
Collaborator

Our current Python Compass run method accepts a dict but serializes it into a string before sending it to rust. In rust it is again deserialized into a serde_json value. Pyo3 has a PyObject type and deserializer we could leverage instead.
@robfitzgerald robfitzgerald added python Applies to the python code rust Applies to the rust code labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Applies to the python code rust Applies to the rust code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robfitzgerald