Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VehicleParameters as an enum #207

Open
nreinicke opened this issue May 10, 2024 · 0 comments
Open

VehicleParameters as an enum #207

nreinicke opened this issue May 10, 2024 · 0 comments
Labels
rust Applies to the rust code

Comments

@nreinicke
Copy link
Collaborator

PR #204 introduced the concept of the VehicleParameter.

@robfitzgerald points out that:

we may want to come back around to this module and relax the design of the VehicleParameters so that queries can provide a subset of the parameters, for example, when that information is not available for a vehicle. we could do this by turning VehicleParameters into an enum and deserializing a Vec from the user query. if that were the case, we could even avoid the mandatory O(n) sweep for each Vec because we could match by type only the relevant restrictions.

@nreinicke nreinicke added the rust Applies to the rust code label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Applies to the rust code
Projects
None yet
Development

No branches or pull requests

1 participant