Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to include ends of chromosomes. #114

Open
avantikalal opened this issue Feb 6, 2020 · 2 comments
Open

Fix to include ends of chromosomes. #114

avantikalal opened this issue Feb 6, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@avantikalal
Copy link
Contributor

Currently get_intervals.py deletes intervals that extend beyond the chromosome length. This means that the last few kilobases of each chromosome are not covered in the intervals and no prediction is made for them when we perform inference.
These bases should somehow be included.
Pad the h5 with zeros beyond the chromosome size, then at the time of writing the bedGraph file trim off the excess zeros.

@ntadimeti ntadimeti added this to the v0.3 milestone Feb 25, 2020
@ntadimeti
Copy link
Collaborator

@avantikalal where is the chromosome length defined ? and how do we know the full length of the chromosome to know how many zeroes to append ?

@ntadimeti ntadimeti added the bug Something isn't working label Jun 1, 2020
@ntadimeti ntadimeti removed this from the v0.3.0 milestone Jul 13, 2020
@ntadimeti
Copy link
Collaborator

De-prioritizing this for v0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants