Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize default metrics/loss inside ModelOutput instead #1164

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Initialize default metrics/loss inside ModelOutput instead #1164

merged 5 commits into from
Jun 30, 2023

Conversation

marcromeyn
Copy link
Contributor

@marcromeyn marcromeyn commented Jun 30, 2023 •
edited
Loading

Goals ⚽

This fixes some issues around running torch.jit.script on a module that included a loss/metric that was already scripted.

@marcromeyn marcromeyn self-assigned this Jun 30, 2023
@marcromeyn marcromeyn added bug Something isn't working area/pytorch labels Jun 30, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1164

@edknv edknv marked this pull request as ready for review June 30, 2023 08:11
@edknv edknv merged commit 94f74b5 into main Jun 30, 2023
35 checks passed
@edknv edknv deleted the torch/default-loss-metrics branch June 30, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcromeyn @edknv