Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix exp_manager.py to work on Windows #10275

Closed
BBC-Esq opened this issue Aug 27, 2024 · 2 comments
Closed

fix exp_manager.py to work on Windows #10275

BBC-Esq opened this issue Aug 27, 2024 · 2 comments
Labels
bug Something isn't working stale

Comments

@BBC-Esq
Copy link

BBC-Esq commented Aug 27, 2024

In the exp_manager.py script, you need to change the line that reads

rank_termination_signal: signal.Signals = signal.SIGKILL

to...

rank_termination_signal: signal.Signals = signal.SIGTERM if os.name == 'nt' else signal.SIGKILL

That way it will work on Windows.

You're welcome.
@BBC-Esq BBC-Esq added the bug Something isn't working label Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BBC-Esq