Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Thrust matrix green #106

Closed
1 task done
Tracked by #102
jrhemstad opened this issue Jun 21, 2023 · 4 comments
Closed
1 task done
Tracked by #102

Make Thrust matrix green #106

jrhemstad opened this issue Jun 21, 2023 · 4 comments
Assignees

Comments

@jrhemstad
Copy link
Collaborator

jrhemstad commented Jun 21, 2023

Tasks

  1. gevtushenko
@gevtushenko
Copy link
Collaborator

@allisonvacanti I have a WAR for CUB / llvm builds that should be present in thrust module as well.

Symptom:

this style of line directive is a GNU extension

Solution:

append_option_if_available("-Wgnu" cxx_compile_options)
append_option_if_available("-Wno-gnu-line-marker" cxx_compile_options) # WAR 3916341

@gevtushenko
Copy link
Collaborator

@allisonvacanti I've applied the fix to thrust project as well, which makes everything except CTK 11.1 / llvm 9 green for thrust as well. As soon as the libcu++ issue #108 (comment) is addressed, and #114 is merged, I think this issue can be closed.

@alliepiper
Copy link
Collaborator

Thanks @senior-zero! This is awesome.

@gevtushenko
Copy link
Collaborator

Thrust matrix is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants