Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Validate cuda.parallel type matching in build and execution #2416

Closed
1 task done
gevtushenko opened this issue Sep 17, 2024 · 0 comments · Fixed by #2429
Closed
1 task done

[FEA]: Validate cuda.parallel type matching in build and execution #2416

gevtushenko opened this issue Sep 17, 2024 · 0 comments · Fixed by #2429
Assignees
Labels
feature request New feature or request.

Comments

@gevtushenko
Copy link
Collaborator

Is this a duplicate?

Area

General CCCL

Is your feature request related to a problem? Please describe.

Today, cuda.parallel API consists of build and execution stages. During the build stage, we instantiate C++ templates and form a cubin. During execution stage, we use this cubin. There's no type validation during execution step. This might create issues where user build cuda.parallel algorithm for, say, int, but execute it on double leading to a silent corruption.

Describe the solution you'd like

We should validate that types used during execution step match ones provided in build here:

# TODO Assert that types match the ones used in the constructor

This PR can be closed by a test illustrating that an exception is thrown when passing not matching types during execution step.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants