Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .upstream-tests #935

Closed
brycelelbach opened this issue Sep 18, 2020 · 3 comments
Closed

Rename .upstream-tests #935

brycelelbach opened this issue Sep 18, 2020 · 3 comments
Assignees
Labels
libcu++ For all items related to libcu++

Comments

@brycelelbach
Copy link
Collaborator

Especially after the refactoring away from submodules, I find the name of this directory very confusing; the upstream tests (e.g. raw libc++ tests) live in libcxx/test, not .upstream-tests.

@griwes
Copy link
Collaborator

griwes commented Sep 18, 2020

I'm planning to do away with the subdirectory entirely and just promote the symlinks to be the actual directories inside .upstream-tests.

@griwes
Copy link
Collaborator

griwes commented Sep 18, 2020

Also if I remember my reasoning back when it was added, there was some kind of an expectation that we'd have some CUDA-specific tests outside of the libc++ test framework, so the name isn't "tests of the upstream", it's "tests that come from the upstream". But I agree that in hindsight, it's not the best name imaginable ;)

@jrhemstad jrhemstad added the libcu++ For all items related to libcu++ label Feb 22, 2023
@jarmak-nv jarmak-nv transferred this issue from NVIDIA/libcudacxx Nov 8, 2023
@jrhemstad jrhemstad assigned wmaxey and unassigned griwes Nov 8, 2023
@jrhemstad
Copy link
Collaborator

#1075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libcu++ For all items related to libcu++
Projects
Archived in project
Development

No branches or pull requests

4 participants