Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Add perfect_hashing probing scheme #487

Open
sleeepyjack opened this issue May 16, 2024 · 2 comments
Open

[FEATURE]: Add perfect_hashing probing scheme #487

sleeepyjack opened this issue May 16, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers P2: Nice to have Desired, but not necessary type: feature request New feature request

Comments

@sleeepyjack
Copy link
Collaborator

sleeepyjack commented May 16, 2024

Is your feature request related to a problem? Please describe.

Perfect hash functions describe an injective mapping from the input key domain into the hash map's slot index domain. In other words, Each distinct key hashes to a distinct slot in the map.

This setup allows for a set of optimizations:

  • Perfect hash functions don't require any probing logic, since there can't be any colliding key in a slot that is not equal to the probe key
  • The injectivity constraint guarantees that any index value produced by the hash function is smaller than the map's capacity. Thus, we can get rid of the remainder computation.
  • Key equality comparison can be simplified, i.e., we only have to check if the key in the slot is equal to a sentinel or not.

Describe the solution you'd like

Add a new class cuco::perfect_hashing<class Hash> to our probing scheme zoo which behaves as follows:

When the dereferencing operator of the probing iterator is called for the first time (at the initial probing position), return slots + hash(key). After incrementing the iterator, always return end(), meaning that there is at most one probing step.

A user must ensure that the Hash function in combination with the input key set actually forms a perfect hash function, and the maximum hash values is smaller than the map's capacity. Otherwise behavior is undefined.

Notes on the implementation:

  • Currently each of our probing schemes uses the same probing_iterator class. This new probing scheme doesn't fit into the logic of the existing iterator. Thus I propose to let each probing scheme define its own probing_iterator as a member class.
  • Since perfect hashing only requires bitwise comparison against the sentinel, we ignore any user-specified KeyEqual operator.

Describe alternatives you've considered

There is one more optimization we could additionally apply, but I would vote against it due to technical reasons:

Perfect hashing guarantees that there are no collisions. Thus, we could insert keys using non-atomic STG instructions, which has proven to be significantly faster compared to atomic CAS operations.
This however leads to some undesireful side effects due to the relaxed memory ordering of the GPU, which ultimately leads to implausible return values from some of our APIs (insert_and_find and also bulk insert; see example in the bottom paragraph of #475 (comment)).

If this optimization is desired, it can still be enabled by specifying cuda::thread_scope_thread when instantiating the map type. This is a bit hacky but I think it's better than breaking the existing logic, introducing spurious errors in the aforementioned return values.

Additional context

See discussion #475

Tasks

No tasks being tracked yet.
@sleeepyjack
Copy link
Collaborator Author

sleeepyjack commented May 16, 2024

Few more implementation details come to my mind:

  • When doing an insert with perfect hashing, we don't need to check the content of the slot first. Instead, we can directly issue the store instruction. This is handled outside the probing iterator. I think we have to add a constexpr switch to trigger this specialized code path to the insert device function.
  • Key equality comparison is also handled outside of the probing iterator. This probably also needs a dedicated code path

@njones93531
Copy link
Contributor

As mentioned in slack, I would like to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P2: Nice to have Desired, but not necessary type: feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants