Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Audit expression name and SQL function name in supportedExprs.csv #392

Closed
nartal1 opened this issue Jun 27, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Jun 27, 2023

Describe the bug
SQL functions which are supported in Spark-Rapids are classified as unsupported expressions due to current technique of identifying unsupported expressions. Currently we take Expression column and SQL func column from supportedExprs.csv and remove _ for SQL_func ( as for almost all expressions, expression name and SQL functions are same when _ is removed Ex: ArrayExcept -> array_except).
But there are some exceptions (First -> first, first_value), we need to preserve_ for those SQL functions where Expression name and SQL_func name is different. Found an issue with this here - #381

We need to audit supportExprs.csv to go over whole list to make sure we cover all the expressions where Expression name is different from SQL function name.

Expected behavior
Supported expressions should not displayed in unsupportedExpressions column

Environment details (please complete the following information)
Onprem, all CSP's

Additional context
Add any other context about the problem here.

@nartal1
Copy link
Collaborator Author

nartal1 commented Jul 6, 2023

This isn't required anymore as we are searching for both Expression name and SQL function name(s) in this PR - #408 . Closing this.

@nartal1 nartal1 closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

No branches or pull requests

3 participants