You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
This is based on the comment #408 (review) .
Currently we convert the expressions string to lower case before comparing. We need to revisit this if some of the conversions are redundant OR not required in the first place.
Targets
Occurrences of 'toLowerCase' in Project with mask '*.scala'
Found Occurrences in Project with mask '*.scala' (26 usages found)
Unclassified (26 usages found)
rapids-4-spark-tools_2.12 (26 usages found)
com.nvidia.spark.rapids.tool.planparser (3 usages found)
DataWritingCommandExecParser.scala (1 usage found)
41 new ExecInfo(sqlID, s"${node.name.trim} ${wStub.dataFormat.toLowerCase.trim}", "",
SQLPlanParser.scala (2 usages found)
356 ignoreExpressions.contains(expr.toLowerCase)
704 functionMatches.map(_.group(1)).filter(_.toLowerCase() != "cast")
com.nvidia.spark.rapids.tool.profiling (8 usages found)
AutoTuner.scala (3 usages found)
626 .getOrElse("false").toLowerCase
1063 val sizesArr = size.toLowerCase.split("(?=[a-z])")
1075 val sizesArr = size.toLowerCase.split("(?=[a-z])")
ProfileOutputWriter.scala (1 usage found)
63 val suffix = header.replace(" ", "_").toLowerCase
QualificationInfoUtils.scala (4 usages found)
171 if (logType.toLowerCase.equals("dataset")) {
173 } else if (logType.toLowerCase.equals("udfds")) {
175 } else if (logType.toLowerCase.equals("udffunc")) {
177 } else if (logType.toLowerCase.equals("dsanddf")) {
com.nvidia.spark.rapids.tool.qualification (14 usages found)
PluginTypeChecker.scala (12 usages found)
115 x => (x._1.toLowerCase.replaceAll("\\`", ""), x._2))
136 val header = fileContents.head.split(",").map(_.toLowerCase)
189 val header = fileContents.head.split(",").map(_.toLowerCase)
197 val format = cols(0).toLowerCase
198 val direction = cols(1).toLowerCase()
203 }.keys.toSeq.map(_.toLowerCase)
236 val schemaLower = schema.toLowerCase
237 val formatInLower = format.toLowerCase
242 val nsFiltered = dtSupMap(NS).filter(t => schemaLower.contains(t.toLowerCase()))
261 val format = writeFormat.toLowerCase.trim
266 writeFormat.map(x => x.toLowerCase.trim).filterNot(
303 expr.toLowerCase.replace("_", "")
QualificationArgs.scala (2 usages found)
193 order.toLowerCase.startsWith("asc")
197 order.toLowerCase.startsWith("desc")
org.apache.spark.sql.rapids.tool.qualification (1 usage found)
QualificationAppInfo.scala (1 usage found)
179 s"${ds.format.toLowerCase()}[${ds.schema}]"
The text was updated successfully, but these errors were encountered:
Describe the bug
This is based on the comment #408 (review) .
Currently we convert the expressions string to lower case before comparing. We need to revisit this if some of the conversions are redundant OR not required in the first place.
The text was updated successfully, but these errors were encountered: