Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Improve timestampFormat support in GpuJsonScan and make tests consistent with GpuStructsToJson #10044

Open
andygrove opened this issue Dec 13, 2023 · 0 comments
Open

[FEA] Improve timestampFormat support in GpuJsonScan and make tests consistent with GpuStructsToJson #10044

andygrove opened this issue Dec 13, 2023 · 0 comments
Labels
test Only impacts tests

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In PR #9975 we added better tests for reading dates from JSON and this found many bugs. We need to do the same now for timestampFormat.

Describe the solution you'd like
Add better tests for timstampFormat for GpuJsonScan and GpuJsonToStructs and fix any bugs found.

Describe alternatives you've considered

Additional context
@andygrove andygrove added bug Something isn't working feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 13, 2023
@andygrove andygrove self-assigned this Dec 13, 2023
@andygrove andygrove mentioned this issue Dec 13, 2023
Merged
5 tasks
@mattahrens mattahrens added test Only impacts tests and removed bug Something isn't working feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 19, 2023
@mattahrens mattahrens mentioned this issue Dec 19, 2023
Open
62 tasks
@andygrove andygrove removed their assignment Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andygrove @mattahrens