Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] setting timestampFormat/dateFormat for JsonToStructs appears to fall back too often and also not often enough #10485

Open
revans2 opened this issue Feb 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 23, 2024

Describe the bug
I am not 100% sure what is happening here as there is code in place for this, and there appears to be some tests in ScanJson for it. But the tests and the checks don't look like they are compatible with each other and every time I try to set the timestampFormat, for from_json it fallback back to the CPU. I don't know why. Even if I set it to the one hard coded value that should work.

But for dateFormat I am able to set it to something like MMM yyyy which is a format that we don't support, and it does not fall back to the CPU. Instead we get an error about how when we try to convert it to the format that CUDF wants it is not supported.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 23, 2024
@revans2 revans2 changed the title [BUG] setting timestampFormat/dateFormat for JsonToStructs appears to always fall back to the CPU [BUG] setting timestampFormat/dateFormat for JsonToStructs appears to always fall back too often and also not often enough Feb 23, 2024
@revans2 revans2 changed the title [BUG] setting timestampFormat/dateFormat for JsonToStructs appears to always fall back too often and also not often enough [BUG] setting timestampFormat/dateFormat for JsonToStructs appears to fall back too often and also not often enough Feb 23, 2024
@revans2 revans2 mentioned this issue Feb 26, 2024
62 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants