Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of leaks in tests #6947

Open
jlowe opened this issue Oct 28, 2022 · 1 comment
Open

Improve detection of leaks in tests #6947

jlowe opened this issue Oct 28, 2022 · 1 comment
Labels
task Work required that improves the product but is not user facing test Only impacts tests

Comments

@jlowe
Copy link
Member

jlowe commented Oct 28, 2022

Is your feature request related to a problem? Please describe.
Currently it's possible for code to introduce resource leaks that occur during tests but the tests do not fail when the leak is detected. This can result in leaks "building up" over time, only to be found much later when someone investigate the logs from test runs and notices leak stacktraces in the log output.

Describe the solution you'd like
A system property can be set which would change the leak detection code to not just log a stacktrace of where the leak occurred but also cause the running test to fail in some way. That way when a leak is detected during GC, RMM shutdown, etc, it's more
likely this will be caught by the premerge builds.

Describe alternatives you've considered
Update the premerge and/or nightly test jobs to scrape the test logs looking for signs of leaks being logged.

@jlowe jlowe added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Oct 28, 2022
@ttnghia
Copy link
Collaborator

ttnghia commented Feb 15, 2023

Comment to subscribe to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing test Only impacts tests
Projects
None yet
Development

No branches or pull requests

2 participants