Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] test_conv_dec_to_from_hex for different datagen_seeds #9784

Open
gerashegalov opened this issue Nov 18, 2023 · 0 comments
Open

[BUG] test_conv_dec_to_from_hex for different datagen_seeds #9784

gerashegalov opened this issue Nov 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Nov 18, 2023

Describe the bug

[to_plus10-from_10] fails in CI for DATAGEN_SEED=1700253320

[2023-11-17T20:39:30.496Z] --- CPU OUTPUT
[2023-11-17T20:39:30.496Z] +++ GPU OUTPUT
[2023-11-17T20:39:30.496Z] @@ -1486,7 +1486,7 @@
[2023-11-17T20:39:30.496Z]  Row(a='608899526863483049', conv(a, 10, 10)='608899526863483049')
[2023-11-17T20:39:30.496Z]  Row(a='616420757253954442', conv(a, 10, 10)='616420757253954442')
[2023-11-17T20:39:30.496Z]  Row(a='435761768247103195', conv(a, 10, 10)='435761768247103195')
[2023-11-17T20:39:30.496Z] -Row(a='\x1f5¦½dÎà\x0b 9', conv(a, 10, 10)='0')
[2023-11-17T20:39:30.496Z] +Row(a='\x1f5¦½dÎà\x0b 9', conv(a, 10, 10)='5')
[2023-11-17T20:39:30.496Z]  Row(a='-272022217013155335', conv(a, 10, 10)='18174721856696396281')
[2023-11-17T20:39:30.496Z]  Row(a='180251617239943975', conv(a, 10, 10)='180251617239943975')
[2023-11-17T20:39:30.496Z]  Row(a='-3498518660140742', conv(a, 10, 10)='18443245555049410874')

we do not cover the full range of inputs conv, probably need to make a more accurate estimation of the max string length we support.

Environment details (please complete the following information)
multiple

Additional context

@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify labels Nov 18, 2023
@gerashegalov gerashegalov changed the title [BUG] test_conv_dec_to_from_hex[to_plus10-from_10] fails in CI for DATAGEN_SEED=1700253320 [BUG] test_conv_dec_to_from_hex for different datagen_seeds Nov 18, 2023
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants