Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support to_date with non-UTC timezones without DST #9927

Closed
NVnavkumar opened this issue Dec 1, 2023 · 6 comments · Fixed by #10100
Closed

[FEA] Support to_date with non-UTC timezones without DST #9927

NVnavkumar opened this issue Dec 1, 2023 · 6 comments · Fixed by #10100
Assignees
Labels
feature request New feature or request

Comments

@NVnavkumar
Copy link
Collaborator

I wish we can support to_date with CST(China Time Zone) support.

SELECT to_date(col) from xxx;
@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 1, 2023
@NVnavkumar NVnavkumar changed the title [FEA] Support to_date with CST timezone [FEA] Support to_date with non-UTC timezones without DST Dec 1, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 5, 2023
@NVnavkumar NVnavkumar assigned razajafri and unassigned razajafri Dec 13, 2023
@NVnavkumar
Copy link
Collaborator Author

@nvliyuan What is the specific string format needed for to_date needed here?

@nvliyuan
Copy link
Collaborator

Confirmed in customers query, they only use default format.(yyyy-MM-dd)

@winningsix
Copy link
Collaborator

Thanks. Then it's on the list of our supported formats. It's depending on #9997 @razajafri

'yyyy-MM-dd', 'yyyy-MM', 'yyyy/MM/dd', 'yyyy/MM', 'dd/MM/yyyy',  'MM-dd', 'MM/dd', 'dd-MM', 'dd/MM'

@NVnavkumar NVnavkumar assigned winningsix and NVnavkumar and unassigned razajafri Dec 15, 2023
@NVnavkumar
Copy link
Collaborator Author

NVnavkumar commented Dec 15, 2023

to_date(date_str, fmt) is actually replaced at runtime with cast(gettimestamp(date_str, fmt, TimestampType, Some(<session timezone>), false) as date). So it actually depends on #10035 which might depend on #9997

@NVnavkumar
Copy link
Collaborator Author

Ultimately once the dependency issues are completed, this is just a verification task.

@NVnavkumar
Copy link
Collaborator Author

Basically this requires GpuGetTimestamp work with a non-UTC timezone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
5 participants