Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Fill ServiceProvider with registering things on package creation #72

Open
baltun opened this issue Feb 3, 2021 · 1 comment
Open

Fill ServiceProvider with registering things on package creation #72

baltun opened this issue Feb 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@baltun
Copy link

baltun commented Feb 3, 2021

It would be better if on creation ServiceProvider will be filled with registering code for views, migrations, routes and so on (some of these abilities could be commented to make an ability to developer to uncomment to begin to use it

@Naoray
Copy link
Owner

Naoray commented Feb 4, 2021

I'd not want to add commented code to the ServiceProvider. Instead we could look into providing additional options for the make:package command and based on the used options we could then generate code within the ServiceProvider

// creating a package with `resources/views`, `config/package_config_name`, `database/migrations/`
// and the corresponding code within the service provider to load them
php artisan make:package --views --config=package_config_name --migrations --routes

// doing all the above
php artisan make:package --all

@Naoray Naoray added the enhancement New feature or request label Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants