Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stwfsapy an optional dependency #699

Closed
cbartz opened this issue May 5, 2023 · 0 comments · Fixed by #700
Closed

Make stwfsapy an optional dependency #699

cbartz opened this issue May 5, 2023 · 0 comments · Fixed by #700
Milestone

Comments

@cbartz
Copy link
Contributor

cbartz commented May 5, 2023

We would like to release the STWFSA backend into the community. To ensure that Annif is not fundamentally dependent on the compatibility of stwfsapy with Annif, we suggest making stwfsapy an optional dependency in Annif. This way, stwfsapy can still be used within Annif but cannot break the entire system in case of temporary incompatibilities, because it can be removed more easily than a core dependency.

This can be achieved by declaring stwfsapy as an optional dependency in pyproject.toml. The import statement inside annif/backend/init.py should be wrapped by a try...except block to handle any import errors.

@osma osma added this to the 1.0 milestone May 5, 2023
@cbartz cbartz changed the title Make stfwsapy an optional dependency Make stwfsapy an optional dependency May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants