Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams not cleaned up in WaveRecorder when Exception occurs #26

Closed
walterg2 opened this issue Jul 23, 2018 · 2 comments
Closed

Streams not cleaned up in WaveRecorder when Exception occurs #26

walterg2 opened this issue Jul 23, 2018 · 2 comments
Assignees
@NateRickard

Comments

@walterg2
Copy link

Problem Statement:
While using the AudioRecorder plugin, if a situation occurs where the AudioStream implementation throws an exception (the easiest one to replicate is to deny access to the Microphone), the WaveRecorder does not dispose of the FileStream and BinaryWriter objects. This makes it so you cannot clean up the directory and file that is requested the wav file to be saved to.
@NateRickard NateRickard self-assigned this Aug 8, 2018
@NateRickard
Copy link
Owner

@walterg2 I've released v1.0.2-pre where I attempted to handle this with some additional cleanup. However, I can't reproduce the exception when I'm debugging... tried to decline the iOS mic prompt but it seems to allow me to continue to use the APIs w/o throwing errors. Can you install and verify this release takes care of the issue you're seeing?

@NateRickard
Copy link
Owner

Closing this issue but would be great if anyone could confirm this is fixed in the latest releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateRickard NateRickard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@walterg2 @NateRickard