Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEADS UP: Refactor coming...Prepare. #119

Closed
NathanWalker opened this issue Jun 7, 2016 · 4 comments
Closed

HEADS UP: Refactor coming...Prepare. #119

NathanWalker opened this issue Jun 7, 2016 · 4 comments
Assignees

Comments

@NathanWalker
Copy link
Owner

If you are using this seed, please read carefully:
There is a very nice refactor coming down the pipeline soon from the parent seed:
mgechev/angular-seed#959

It should hopefully be the last fairly major refactor to land, but you should prepare your projects if you intend to merge in latest upstream when it lands.

Preparation checklist:

Doing the above will ensure that you can merge in the upstream changes when the refactor lands with lesser conflicts. You will likely have some but they shouldn't be too bad to sort through.

In the event you have steered way off course and have tons of modifications, getting things together and into their own file or framework would allow you to download a new zip and just drop your custom stuff in.

I will close this once the refactor lands here; it will still be another week or more.

@NathanWalker NathanWalker self-assigned this Jun 7, 2016
@vincentpalita
Copy link
Contributor

Thanks for the heads up @NathanWalker!

@joshwiens
Copy link
Collaborator

I really wish I could get Minko to run a "develop" like branch to merge this stuff into first instead of just hammering everything into master :(

@JakePartusch
Copy link
Contributor

@NathanWalker, #61 will be on hold until these changes come through :/

@NathanWalker
Copy link
Owner Author

The refactor is not going to happen due to complex issues with SystemJS, so disregard this 👍
Multi-platforms are supported by this seed now and more can be integrated using similar setups as was done with {N} and electron integration already.

@JakePartusch Feel free to continue with angular-universal. This could be housed in a server folder in the root similar to how nativescript folder exists in root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants