Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Application Menu not showing on Windows OS #87

Closed
drhoussem opened this issue Jul 30, 2023 · 1 comment
Closed

[Bug]: Application Menu not showing on Windows OS #87

drhoussem opened this issue Jul 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@drhoussem
Copy link

What happened?

The menu is registred in Service Provider but it's not showing

How to reproduce the bug

Register a menu in NativeAppServiceProvider.php

Menu::new()
            ->submenu(
                'About',
                Menu::new()
                    ->link('https://test.co', 'Test')
            )
            ->fileMenu()
            ->register();

Run php artisan native:serve

The app will show on screen but application menu is not showing

Package Version

0.2.0

PHP Version

8.1

Laravel Version

10.x

Node Version

18.16

Which operating systems does with happen with?

Windows

Notes

No response

@drhoussem drhoussem added the bug Something isn't working label Jul 30, 2023
@drhoussem
Copy link
Author

This was not a bug, it was the default behavior because autoHideMenuBar was set to true in electron plugin.
I worked on a feature to make this optional locally and I was about to make a pull request till I saw that there was already a PR #84 that introduced this feature (merged in 0.3.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant