Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Import of nimndata in parser #322

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

aaronmgdr
Copy link
Contributor

Purpose / Goal

On a fresh install off this package whenever I tried to use the parse I would run into a an error

  Could not locate module ../src/nimndata mapped as:
    /Users/{my project...}/src/$1.

I notice that all the other imports in the parse.js file use "./filename" for imports. So i changed this to match.

Type

  • Bug Fix

Bookmark this repository for further updates.

On a fresh install of this package the import style being references as "../src" caused this to fail.
@coveralls
Copy link

coveralls commented Feb 26, 2021

Coverage Status

Coverage remained the same at 87.983% when pulling fe41f2d on aaronmgdr:patch-1 into 51cd0dc on NaturalIntelligence:master.

@aaronmgdr
Copy link
Contributor Author

if this is intentional happy to leave

@amitguptagwl amitguptagwl merged commit e6eeefa into NaturalIntelligence:master Feb 26, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants