-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for true in-memory zip handling #85
Comments
perhaps a better fix is to allow setting of the |
I did try this and it seemed to work in itself, however it showed that the AWS S3 (seeking) Stream Wrapper isn't written very well - and instead of having a page-cache LRU it just keeps the whole file up to where seeked - so useless for my purposes. Still having the control over php-zip's temp memory cache level is quite nice. For reference, my experiment is available here - kaldor@0dc0e8c |
I was initially going to use memory, but temp with adjustable memory was more flexible and achieved the same results for me - I'm happy with my php-zip changes (for my purpose), I was just scuppered by the AWS S3 StreamWrapper to have end-to-end in-memory only access of huge zip files in S3. (I did use Perhaps, instead of passing a |
Description
I'm using php-zip in an AWS Lambda with a zip in S3 using the seekable stream wrapper - which works great!
However, the use of
php://temp
means the lambda's small storage area fills up quickly and causes problems.As I'm using a lambda with 10GB of RAM (storage is <500MB) it would be great if instead we could optionally support
php://memory
instead.I'm likely to fork and have a go at this tomorrow, but I've no idea which way of implementing it would be acceptable for a PR (if any).
Example
The text was updated successfully, but these errors were encountered: