From dad3f112edf4a365485b1241e8ba8eb74c5ad744 Mon Sep 17 00:00:00 2001 From: NejcZdovc Date: Thu, 3 Aug 2017 16:34:12 -0500 Subject: [PATCH] Moves hrePreview from Frame Resolves #10194 Auditors: @bsclifton Test Plan: --- app/renderer/components/frame/frame.js | 14 +----- app/renderer/components/frame/hrefPreview.js | 45 ++++++++++++++++++++ 2 files changed, 47 insertions(+), 12 deletions(-) create mode 100644 app/renderer/components/frame/hrefPreview.js diff --git a/app/renderer/components/frame/frame.js b/app/renderer/components/frame/frame.js index fe2b74bda14..ea0d4d366b7 100644 --- a/app/renderer/components/frame/frame.js +++ b/app/renderer/components/frame/frame.js @@ -16,6 +16,7 @@ const getSetting = require('../../../../js/settings').getSetting // Components const ReduxComponent = require('../reduxComponent') const FullScreenWarning = require('./fullScreenWarning') +const HrefPreview = require('./hrefPreview') const MessageBox = require('../common/messageBox') // Store @@ -884,8 +885,6 @@ class Frame extends React.Component { props.isActive = frameStateUtil.isFrameKeyActive(currentWindow, frame.get('key')) props.showFullScreenWarning = frame.get('showFullScreenWarning') props.location = location - props.hrefPreview = frame.get('hrefPreview') - props.showOnRight = frame.get('showOnRight') props.tabId = tabId props.showMessageBox = tabMessageBoxState.hasMessageBoxDetail(state, tabId) @@ -944,16 +943,7 @@ class Frame extends React.Component { webviewContainer: true, isPreview: this.props.isPreview })} /> - { - this.props.hrefPreview - ?
- {this.props.hrefPreview} -
- : null - } + { this.props.showMessageBox ? + {this.props.hrefPreview} + + } +} + +module.exports = ReduxComponent.connect(HrefPreview)