Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch screen inputs become stuck due to known issue with input system #3924

Open
Raemien opened this issue Jul 15, 2023 · 0 comments
Open

Touch screen inputs become stuck due to known issue with input system #3924

Raemien opened this issue Jul 15, 2023 · 0 comments
Labels
Bug Something isn't working

Comments

@Raemien
Copy link

Raemien commented Jul 15, 2023

Describe the bug?

There exists a bug in Unity's 1.0.2 input system package that causes Touch.activeTouches to become stuck if multiple touches occur within the same frame. Touches that occur in this window of time will not be released until the application looses focus.

This is most easily seen in situations where the application briefly freezes or experiences a low framerate.

The issue in question was fixed in com.unity.inputsystem version 1.1.0, though NeosVR still uses version 1.0.2.
https://docs.unity3d.com/Packages/[email protected]/changelog/CHANGELOG.html
(See 2020-08-20 patch notes for 1.1.0-preview.1)

Relevant issues

N/A

To Reproduce

  • Lower the application's framerate or briefly ensure the main thread busy.
  • Press and hold any part of the touch screen until the next frame.
  • There should now be a "phantom touch" event that will persist until the application looses focus.

Expected behavior

Touch events should be disposed after the user has lifted their finger from the touch screen.

Log Files

No response

Screenshots

No response

How often does it happen?

Always

Does the bug persist after restarting Neos?

No

Neos Version Number

2022.2.28.1310

What Platforms does this occur on?

Android / Quest

Link to Reproduction Item/World

No response

Did this work before?

No

If it worked before, on which build?

No response

Additional context

This issue does not strongly impede UI navigation (which seems to be the main purpose of TouchDriver), though will pose an issue if Neos implements touch screen gamepad controls in future.

The issue was discovered while implementing such a feature as a NeosModLoader mod.
https://github.com/Raemien/NeosTouchControls

Reporters

Raemien / @Raemien

@Raemien Raemien added the Bug Something isn't working label Jul 15, 2023
@Raemien Raemien changed the title TouchDriver inputs become stuck due to known issue with input package Touch screen inputs become stuck due to known issue with input system Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant