Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css modules 处理样式文件规则与 create-react-app 保持一致 #1266

Closed
lbb00 opened this issue Nov 27, 2018 · 6 comments
Closed

css modules 处理样式文件规则与 create-react-app 保持一致 #1266

lbb00 opened this issue Nov 27, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@lbb00
Copy link

lbb00 commented Nov 27, 2018

还是就按照 create-react-app 的规范来更具有一致性,就是以 .module.css 结尾的就按 css modules 处理,其他的都是全局

#933 (comment)

css modules 是一个额外的附加功能,不应该在开启后影响原有的模式。

讨论并追踪一下?

@taro-bot
Copy link

taro-bot bot commented Nov 27, 2018

欢迎提交 Issue~

如果你提交的是 bug 报告,请务必遵循 Issue 模板的规范,尽量用简洁的语言描述你的问题,最好能提供一个稳定简单的复现。🙏🙏🙏

如果你的信息提供过于模糊或不足,或者已经其他 issue 已经存在相关内容,你的 issue 有可能会被关闭。

Good luck and happy coding~

@luckyadam
Copy link
Member

我觉的比较合理,目前是所有的样式都当成 module 了

@luckyadam luckyadam added the enhancement New feature or request label Nov 27, 2018
@luckyadam luckyadam self-assigned this Nov 27, 2018
@tourze
Copy link
Contributor

tourze commented Nov 27, 2018

合理

@chunsch
Copy link

chunsch commented Nov 28, 2018

@loveonelong @luckyadam 可以考虑像 umi 最近在讨论的 通用 css modules 方案

@lbb00
Copy link
Author

lbb00 commented Dec 4, 2018

希望能在1.2.0的正式版里规范一下

@lbb00
Copy link
Author

lbb00 commented Dec 17, 2018

看样子应该是解决掉了。关闭了。#1456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants