Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvest should support linking between dashboards #2647

Closed
4 tasks done
rahulguptajss opened this issue Feb 8, 2024 · 4 comments · Fixed by #2931, #2968, #2976 or #3094
Closed
4 tasks done

Harvest should support linking between dashboards #2647

rahulguptajss opened this issue Feb 8, 2024 · 4 comments · Fixed by #2931, #2968, #2976 or #3094
Assignees
Labels
24.08 feature New feature or request status/done

Comments

@rahulguptajss
Copy link
Contributor

rahulguptajss commented Feb 8, 2024

  • Update the NFS troubleshooting and dependent dashboards to use our general linking strategy
  • Handle bin/grafana export use-case
  • Ensure the uuid changes work with Docker Compose workflow (provisioned dashboards)
  • Only link tables and link to the dashboard that matches the column
@rahulguptajss rahulguptajss added the feature New feature or request label Feb 8, 2024
@rahulguptajss rahulguptajss self-assigned this Feb 8, 2024
@rahulguptajss rahulguptajss removed their assignment Mar 19, 2024
@cgrinds cgrinds changed the title Investigate linking among dashboards Harvest should support linking between dashboards Mar 26, 2024
@cgrinds
Copy link
Collaborator

cgrinds commented Mar 26, 2024

The NFS troubleshooting dashboard contributed by Rusty Brown #2766 includes linking and it works well. It's also possible to link to a single dashboard's panel as Rahul mentioned #2766 (comment)

Linking requires stable dashboard uids, which means we need to change how Harvest import/exports dashboards. We discussed a few different ways to change import:

  1. pre-check during import that fails if a dashboard with a given uid already exists
  2. overwrite on import and document how to rollback to an earlier version with Grafana's version support

@cgrinds
Copy link
Collaborator

cgrinds commented May 23, 2024

To support a provisioned workflow, like the ones that Docker Compose and NABox use, we need to embrace the Grafana way. Hard-code uid with a UUID-like identifier and use that uid for linking. Stop doing Harvest versioned Grafana folders.

@Hardikl
Copy link
Contributor

Hardikl commented May 28, 2024

For 1st milestone,
I am planning to add the links in SVM column, Aggregate column in Volume table in Volume dashboard which would open SVM/Aggregate dashboard with chosen SVM/Aggregate from the link.

image

@Hardikl Hardikl linked a pull request May 28, 2024 that will close this issue
@Hardikl Hardikl reopened this Jun 5, 2024
@Hardikl Hardikl linked a pull request Jun 5, 2024 that will close this issue
@Hardikl Hardikl reopened this Jun 6, 2024
@Hardikl Hardikl linked a pull request Jun 10, 2024 that will close this issue
@rahulguptajss rahulguptajss self-assigned this Aug 9, 2024
@rahulguptajss
Copy link
Contributor Author

verfied in 24.08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment