Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less intrusive method of tracking subscriptions? #9

Open
chriszrc opened this issue Nov 22, 2017 · 1 comment
Open

Less intrusive method of tracking subscriptions? #9

chriszrc opened this issue Nov 22, 2017 · 1 comment

Comments

@chriszrc
Copy link

I found this library because it was mentioned on SO:

https://stackoverflow.com/questions/38008334/angular-rxjs-when-should-i-unsubscribe-from-subscription

I really liked the idea of tackling this problem with an unobtrusive approach like decorators, but the approach you've laid out still seems like too much boilerplate (all the takeUntils). What if the decorator instead used AOP and wrapped subscribe calls, then you'd just need the decorator and the ngOnDestroy method? Did you consider such an approach?

@NetanelBasal
Copy link
Owner

Can you give me an example, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants