Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended dry-run for all procedures #455

Open
ilia1243 opened this issue Jun 1, 2023 · 1 comment
Open

Extended dry-run for all procedures #455

ilia1243 opened this issue Jun 1, 2023 · 1 comment
Assignees
Labels

Comments

@ilia1243
Copy link
Collaborator

ilia1243 commented Jun 1, 2023

Consider implementing new dry-run or replace existing --without-act.

  • Do not change anything on cluster or in input Kubemarine files.
  • Generate, enrich, compile as much as possible
    • Compile plugin templates
    • dry-run helm if it is supported
    • Enrich default plugins
    • Generate different files in dump (etc_hosts, haproxy configs, etc.) without upload.
    • Generate final inventory file without replacing of initial (as --without-act currently does)
    • Other
  • Consider restrictions when generation of something that depends on real work on cluster (for example, template plugins sometimes depend on shell command through runtime_vars).
  • In case if it is implemented only locally, consider adding this to kubemarine selftest.
@pranavcracker pranavcracker linked a pull request Jun 26, 2023 that will close this issue
5 tasks
@Deo121996
Copy link

Approach:
For implementing the dry-run we are setting the dry-run field in a cluster context. actual calls for the write function will be received at the wrapper function to prevent actual executions on nodes for sudo/run/put(etc) functions that are making actual changes to the nodes. So whenever the Kubemarine procedure calls to run sudo/run/put it just prints a debug log and all the functionality works similarly except uploading files to the nodes or executing commands on the nodes.

Status:
Currently completed dry-run implementation for install, upgrade, add_node, and reboot procedure. Working on remaining procedures to support dry-run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants