Tests are needed

[mcpeak]

We have had an issue where Aardvark was broken and not updating because of a recent PR. Originally we didn't prioritize tests because we planned to deprecate Aardvark, but now it seems like a useful caching layer for this data. We need tests to cover the core logic so we can continue to accept upstream commits with confidence.

[JohnVonNeumann]

What projects other than Repokid are utilising Aardvark? I know it was mentioned in a different issue that you had no intention of migrating the functionality of Aardvark into Repokid.

[mcpeak]

@JohnVonNeumann the thought is to leave them separate because some people just use Aardvark. Also, even though AWS now provides an Access Advisor API it runs asynchronously, so it's useful to have a caching layer. Having to wait for the Access Advisor updates inline with Repokid would slow down the repoing process significantly.

That being said, @MonkeySecurity is going to be doing more work on Repokid/Aardvark than me for a while, so I'd like to hear his thoughts on this.