Handle keyring.ErrNotFound error instead of panicing. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/tmc/keyring returns keyring.ErrNotFound instead of a blank password in newer libraries. Handle this case properly by nulling the error, to give the user a chance to set a new password.
|
Nice, thanks! |
coryb
added a commit
that referenced
this pull request
Aug 21, 2017
|
Released in 0.1.15 |
coryb
added a commit
that referenced
this pull request
Aug 31, 2017
Handle keyring.ErrNotFound error instead of panicing.
coryb
added a commit
that referenced
this pull request
Aug 31, 2017
This was referenced Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/tmc/keyring returns keyring.ErrNotFound instead of a blank password in newer libraries. Handle this case properly by nulling the error, to give the user a chance to set a new password.
This makes go-jira compatible with the newer versions which now incorporate a fix for working out-of-the-box on Linux.