-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition not updating comments #45
Comments
Not sure, adding comments in transitions seem to work for me, but I have not tried specifically with the Done status on Scrum board. If you run the operation with --verbose you should see the content we actually send and the response we get back. I guess double-check that we are actually sending the comment you expect to see? -Cory |
|
Whelp, that was not useful :) I think a few extra -v -v options will make it more verbose. I tried again on some of my issues and I can reproduce what you are seeing. I can set the comment in the document, which is getting posted:
But when I actually look at the issue there is no comment posted. I am not sure why Jira is accepting the update to comments then dropping it on the floor. Perhaps only some transitions allow for comments (like Close). -Cory |
Would there be any downside to switching it up so that it submits a comment, then submits a transition, as opposed to submitting both as a combo? The former would still work for "Close," but also add every other transition type. |
Hey I tested out the "Close" case, it also does not seem to update a comment. I am confused, pretty sure this used to work, but not sure what is going on. Perhaps this never worked and I just never noticed. We could split up the posts, but I am hoping not to. The YAML template that is edited is just literally posted to Jira (after converting YAML -> JSON), if we split up the steps then my code has to be smart enough to pull the YAML document apart and only post relevent piece for the comment/transition calls. Not impossible, just a lot more complicated that any other operation we support. I am going to do a bit of research to see if I can figure out why this is not working as expected, and why Jira is not throwing an error on the comment update but seeming dropping it on the floor instead. -Cory |
Right on, thx. I hope to learn golang and jump in with PRs at some point! |
I contacted my Jira admin and this is what he said:
So basically adding comments will only work with To prevent That said, I probably wont have time to work on this fix for a while. -Cory |
…support comment updates during transtion
Fixed in latest release: https://github.com/Netflix-Skunkworks/go-jira/releases/tag/v1.0.3 We will now call the add-comment api directly if the comment is now allowed in transition. |
Howdy,
When I
jira trans "Done" ID
, I get an expectedWhile the transition is successful, any comments put into the comment body don't appear anywhere in the JIRA GUI (Activity/All). I know this is a "custom" (default Scrum board) transition to a "Done" status, but aren't the comments a generic property of issues?
Thanks!
The text was updated successfully, but these errors were encountered: