Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdaptiveBlockingExecutor.Builder differs critically from AdaptiveBlockingExecutor ctor #154

Open
skradel opened this issue Dec 4, 2019 · 0 comments
Open

AdaptiveBlockingExecutor.Builder differs critically from AdaptiveBlockingExecutor ctor #154

skradel opened this issue Dec 4, 2019 · 0 comments

Comments

@skradel
Copy link

skradel commented Dec 4, 2019

The ctor automatically wraps its Limiter in BlockingLimiter whereas the Builder does not, leading to unexpected RejectedExecutionExceptions under common upgrade/update conditions.

I'm going to put together a pull request to at least simplify the application of BlockingLimiter from within the Builder pattern, although it's probably too late to make it the default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skradel