Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/handle null event values #151

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Bug/handle null event values #151

merged 3 commits into from
Jul 24, 2024

Conversation

obgibson
Copy link
Collaborator

Requirements for a pull request

  • Unit tests related to the change have been updated
  • Documentation related to the change has been updated

Description of the Change

A user reported that a metadata value containing the following data broke the UI

"field_name": "execution-triggers",
"value": "[{\"timestamp\": null, \"id\": null, \"name\": null, \"type\": \"event\"}]",

This change handles those null values more robustly.

Alternate Designs

-

Possible Drawbacks

null values in the event are probably masking another underlying problem. Handling them gracefully may not alert the user that there is a problem.

Verification Process

  • Send a trigger with a null id and null name
  • Confirm that the UI does not break and shows unknown for the event name

Release Notes

Handle null values in execution trigger events more robustly.

@obgibson obgibson merged commit 37c98ac into master Jul 24, 2024
3 checks passed
@obgibson obgibson deleted the bug/handle-null-event-values branch July 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant