You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, SubprocessManager and by extension Runner and Deployer hook an interrupt signal handler via either signal or asyncio. This is slightly problematic when integrating metaflow with an existing codebase, which already does its own signal handling, because both registering a signal with either asyncio or signal overrides any previously set signal handler.
I propose abstracting away the hook in SubprocessManager to a new class SignalManager and allowing users to supply their own instance of it to Deployer and Runner. This would be a non-breaking change.
Adding a POC impl in PR.
The text was updated successfully, but these errors were encountered:
Currently,
SubprocessManager
and by extensionRunner
andDeployer
hook an interrupt signal handler via eithersignal
orasyncio
. This is slightly problematic when integrating metaflow with an existing codebase, which already does its own signal handling, because both registering a signal with eitherasyncio
orsignal
overrides any previously set signal handler.I propose abstracting away the hook in
SubprocessManager
to a new classSignalManager
and allowing users to supply their own instance of it toDeployer
andRunner
. This would be a non-breaking change.Adding a POC impl in PR.
The text was updated successfully, but these errors were encountered: