Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: undici adapter #443

Open
ceelias opened this issue Dec 21, 2021 · 2 comments
Open

feature: undici adapter #443

ceelias opened this issue Dec 21, 2021 · 2 comments

Comments

@ceelias
Copy link

ceelias commented Dec 21, 2021

Description

Undici is a built from scratch http client that doesn't use Node's standard http lib. It has has shown to be very performant. Has this been looked at and any plans to implement an adapter?

Relevant Links

@ceelias ceelias changed the title Undici Adapter feature: Undici Adapter Dec 21, 2021
@ceelias ceelias changed the title feature: Undici Adapter feature: undici adapter Dec 21, 2021
@LuudJanssen
Copy link

We're using Undici in a project I'm working on. We're in need of this in the short term, so I'm thinking of writing this adapter myself. If anyone is already working on it, or took a look at it, please let me know.

I'm planning to use Undici's built-in mocking capabilities. I was planning to use nock, which is also used by the adapter-node-http, but it doesn't support Unidici yet, and it's unsure if it ever will.

@LuudJanssen
Copy link

I tried creating the Undici adapter, but the standard mocking tools for Undici don't support asynchronous callbacks. I created an issue, but for now we will be moving away from Undici so we can use Polly.JS with a regular Node HTTP library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants